On Wed, Sep 26, 2012 at 03:50:12PM +0900, Minchan Kim wrote: > The reclaim_clean_pages_from_list reclaims clean pages before > migration so cc.nr_migratepages should be updated. > Currently, there is no problem but it can be wrong if we > try to use the vaule in future. > > Cc: Mel Gorman <mgorman@xxxxxxx> > Cc: Michal Nazarewicz <mina86@xxxxxxxxxx> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> > Cc: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> > Signed-off-by: Minchan Kim <minchan@xxxxxxxxxx> Yeah ok. As you say, it shouldn't actually affect anything currently and cc.migratepages is expected to go out of date after migration meaning we need update_nr_listpages. This patch looks ok though. Acked-by: Mel Gorman <mgorman@xxxxxxx> -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>