Hi Kirill, On Thu, Sep 13, 2012 at 08:37:58PM +0300, Kirill A. Shutemov wrote: > On Thu, Sep 13, 2012 at 07:16:13PM +0200, Andrea Arcangeli wrote: > > Hi Kirill, > > > > On Wed, Sep 12, 2012 at 01:07:53PM +0300, Kirill A. Shutemov wrote: > > > - hpage = alloc_pages(GFP_TRANSHUGE | __GFP_ZERO, HPAGE_PMD_ORDER); > > > > The page is likely as large as a pageblock so it's unlikely to create > > much fragmentation even if the __GFP_MOVABLE is set. Said that I guess > > it would be more correct if __GFP_MOVABLE was clear, like > > (GFP_TRANSHUGE | __GFP_ZERO) & ~__GFP_MOVABLE because this page isn't > > really movable (it's only reclaimable). > > Good point. I'll update the patchset. > > > The xchg vs xchgcmp locking also looks good. > > > > Reviewed-by: Andrea Arcangeli <aarcange@xxxxxxxxxx> > > Is it for the whole patchset? :) It was meant for this one, but I reviewed the whole patchset and it looks fine to me, so in this case it can apply to the whole patchset ;) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>