Hi Kirill, On Wed, Sep 12, 2012 at 01:07:53PM +0300, Kirill A. Shutemov wrote: > - hpage = alloc_pages(GFP_TRANSHUGE | __GFP_ZERO, HPAGE_PMD_ORDER); The page is likely as large as a pageblock so it's unlikely to create much fragmentation even if the __GFP_MOVABLE is set. Said that I guess it would be more correct if __GFP_MOVABLE was clear, like (GFP_TRANSHUGE | __GFP_ZERO) & ~__GFP_MOVABLE because this page isn't really movable (it's only reclaimable). The xchg vs xchgcmp locking also looks good. Reviewed-by: Andrea Arcangeli <aarcange@xxxxxxxxxx> Thanks, Andrea -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>