>-----Original Message----- >From: Borislav Petkov <bp@xxxxxxxxx> [...] >Subject: Re: [PATCH v18 02/19] EDAC: Add scrub control feature > >On Mon, Jan 06, 2025 at 07:34:41PM +0000, Shiju Jose wrote: >> My understanding is that you meant the following changes (diff to this >> patch), for scrub? (and similar for other features). Please let me >> know if you need any corrections. > >Yes, something like that except "select" is evil and should be used only when the >items it selects do not pull in more stuff. And since scrub is all optional, it should >all be depends. > >> diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig index >> 06f7b43a6f78..709bd7ad8015 100644 >> --- a/drivers/edac/Kconfig >> +++ b/drivers/edac/Kconfig >> @@ -9,6 +9,14 @@ config EDAC_ATOMIC_SCRUB config EDAC_SUPPORT >> bool >> >> +config EDAC_FEAT_SCRUB > >EDAC_SCRUB is perfectly fine. > >> + bool >> + help >> + The EDAC scrub feature is optional and is designed to control the >> + memory scrubbers in the system. The common sysfs scrub interface >> + abstracts the control of various arbitrary scrubbing functionalities >> + into a unified set of functions. > >This should come... > >> + >> menuconfig EDAC >> tristate "EDAC (Error Detection And Correction) reporting" >> depends on HAS_IOMEM && EDAC_SUPPORT && RAS > >... in here as it is part of EDAC. > >Thx. > Hi Boris, I have incorporated your suggestions for the next version. However before sending next version, I am wondering are you planning for further review on this v18 series and giving any other feedbacks? Thanks, Shiju
