>-----Original Message----- >From: Borislav Petkov <bp@xxxxxxxxx> >Sent: 07 January 2025 07:32 >To: Shiju Jose <shiju.jose@xxxxxxxxxx> >Cc: linux-edac@xxxxxxxxxxxxxxx; linux-cxl@xxxxxxxxxxxxxxx; linux- >acpi@xxxxxxxxxxxxxxx; linux-mm@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; >tony.luck@xxxxxxxxx; rafael@xxxxxxxxxx; lenb@xxxxxxxxxx; >mchehab@xxxxxxxxxx; dan.j.williams@xxxxxxxxx; dave@xxxxxxxxxxxx; Jonathan >Cameron <jonathan.cameron@xxxxxxxxxx>; dave.jiang@xxxxxxxxx; >alison.schofield@xxxxxxxxx; vishal.l.verma@xxxxxxxxx; ira.weiny@xxxxxxxxx; >david@xxxxxxxxxx; Vilas.Sridharan@xxxxxxx; leo.duran@xxxxxxx; >Yazen.Ghannam@xxxxxxx; rientjes@xxxxxxxxxx; jiaqiyan@xxxxxxxxxx; >Jon.Grimm@xxxxxxx; dave.hansen@xxxxxxxxxxxxxxx; >naoya.horiguchi@xxxxxxx; james.morse@xxxxxxx; jthoughton@xxxxxxxxxx; >somasundaram.a@xxxxxxx; erdemaktas@xxxxxxxxxx; pgonda@xxxxxxxxxx; >duenwen@xxxxxxxxxx; gthelen@xxxxxxxxxx; >wschwartz@xxxxxxxxxxxxxxxxxxx; dferguson@xxxxxxxxxxxxxxxxxxx; >wbs@xxxxxxxxxxxxxxxxxxxxxx; nifan.cxl@xxxxxxxxx; tanxiaofei ><tanxiaofei@xxxxxxxxxx>; Zengtao (B) <prime.zeng@xxxxxxxxxxxxx>; Roberto >Sassu <roberto.sassu@xxxxxxxxxx>; kangkang.shen@xxxxxxxxxxxxx; >wanghuiqiang <wanghuiqiang@xxxxxxxxxx>; Linuxarm ><linuxarm@xxxxxxxxxx> >Subject: Re: [PATCH v18 02/19] EDAC: Add scrub control feature > >On Mon, Jan 06, 2025 at 07:34:41PM +0000, Shiju Jose wrote: >> My understanding is that you meant the following changes (diff to this >> patch), for scrub? (and similar for other features). Please let me >> know if you need any corrections. > >Yes, something like that except "select" is evil and should be used only when the >items it selects do not pull in more stuff. And since scrub is all optional, it should >all be depends. Sure. > >> diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig index >> 06f7b43a6f78..709bd7ad8015 100644 >> --- a/drivers/edac/Kconfig >> +++ b/drivers/edac/Kconfig >> @@ -9,6 +9,14 @@ config EDAC_ATOMIC_SCRUB config EDAC_SUPPORT >> bool >> >> +config EDAC_FEAT_SCRUB > >EDAC_SCRUB is perfectly fine. Sure. I will change. > >> + bool >> + help >> + The EDAC scrub feature is optional and is designed to control the >> + memory scrubbers in the system. The common sysfs scrub interface >> + abstracts the control of various arbitrary scrubbing functionalities >> + into a unified set of functions. > >This should come... > >> + >> menuconfig EDAC >> tristate "EDAC (Error Detection And Correction) reporting" >> depends on HAS_IOMEM && EDAC_SUPPORT && RAS > >... in here as it is part of EDAC. I will move in here. > >Thx. > >-- >Regards/Gruss, > Boris. > >https://people.kernel.org/tglx/notes-about-netiquette Thanks, Shiju
