On 3 Jan 2025, at 17:21, Gregory Price wrote:
> On Fri, Jan 03, 2025 at 12:24:19PM -0500, Zi Yan wrote:
> ... snip ...
>> + {
>> + .procname = "use_mt_copy",
>> + .data = &use_mt_copy,
>> + .maxlen = sizeof(use_mt_copy),
>> + .mode = 0644,
>> + .proc_handler = proc_dointvec_minmax,
>> + .extra1 = SYSCTL_ZERO,
>> + .extra2 = SYSCTL_ONE,
>> + },
>> + {
>> + .procname = "limit_mt_num",
>> + .data = &limit_mt_num,
>> + .maxlen = sizeof(limit_mt_num),
>> + .mode = 0644,
>> + .proc_handler = proc_dointvec_minmax,
>> + .extra1 = SYSCTL_ONE,
>> + .extra2 = SYSCTL_32,
>> + },
>> + {
>> + .procname = "push_0_pull_1",
>> + .data = &push_0_pull_1,
>> + .maxlen = sizeof(push_0_pull_1),
>> + .mode = 0644,
>> + .proc_handler = proc_dointvec_minmax,
>> + .extra1 = SYSCTL_ZERO,
>> + .extra2 = SYSCTL_ONE,
>> + },
>> {
>> .procname = "drop_caches",
>> .data = &sysctl_drop_caches,
>
> Build errors here
Thanks, these changes must be lost during my patch clean time.
>
> ~Gregory
>
> ---
>
> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> index f9ba48cd6e09..bca82e6132b3 100644
> --- a/kernel/sysctl.c
> +++ b/kernel/sysctl.c
> @@ -2093,8 +2093,8 @@ static struct ctl_table vm_table[] = {
> #endif
> {
> .procname = "use_mt_copy",
> - .data = &use_mt_copy,
> - .maxlen = sizeof(use_mt_copy),
> + .data = &sysctl_use_mt_copy,
> + .maxlen = sizeof(sysctl_use_mt_copy),
> .mode = 0644,
> .proc_handler = proc_dointvec_minmax,
> .extra1 = SYSCTL_ZERO,
> @@ -2102,8 +2102,8 @@ static struct ctl_table vm_table[] = {
> },
> {
> .procname = "limit_mt_num",
> - .data = &limit_mt_num,
> - .maxlen = sizeof(limit_mt_num),
> + .data = &sysctl_limit_mt_num,
> + .maxlen = sizeof(sysctl_limit_mt_num),
> .mode = 0644,
> .proc_handler = proc_dointvec_minmax,
> .extra1 = SYSCTL_ONE,
> @@ -2111,8 +2111,8 @@ static struct ctl_table vm_table[] = {
> },
> {
> .procname = "push_0_pull_1",
> - .data = &push_0_pull_1,
> - .maxlen = sizeof(push_0_pull_1),
> + .data = &sysctl_push_0_pull_1,
> + .maxlen = sizeof(sysctl_push_0_pull_1),
> .mode = 0644,
> .proc_handler = proc_dointvec_minmax,
> .extra1 = SYSCTL_ZERO,
Best Regards,
Yan, Zi
