Re: [PATCH 09/12] x86/mm: enable broadcast TLB invalidation for multi-threaded processes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Rik van Riel <riel@xxxxxxxxxxx>
Subject: Re: [PATCH 09/12] x86/mm: enable broadcast TLB invalidation for multi-threaded processes
From: Nadav Amit <nadav.amit@xxxxxxxxx>
Date: Wed, 1 Jan 2025 17:20:01 +0200
Cc: the arch/x86 maintainers <x86@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, kernel-team@xxxxxxxx, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, luto@xxxxxxxxxx, peterz@xxxxxxxxxxxxx, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, zhengqi.arch@xxxxxxxxxxxxx, "open list:MEMORY MANAGEMENT" <linux-mm@xxxxxxxxx>
In-reply-to: <95b614577f5475a919c878d6906d721004c83584.camel@surriel.com>
References: <20241230175550.4046587-1-riel@surriel.com> <20241230175550.4046587-10-riel@surriel.com> <E03A9B6B-8DB3-4777-A458-E6DC85E2EF9E@gmail.com> <95b614577f5475a919c878d6906d721004c83584.camel@surriel.com>
User-agent: Mozilla Thunderbird



On 01/01/2025 6:42, Rik van Riel wrote:

Fixed for the next version.


Thanks Rik,

Admittedly, I don't feel great about my overall last review - it mostlyfocused on style and common BKMs.

I still don't quite get the entire logic. To name one thing that I don'tunderstand: why do we need broadcast_asid_list and the complicated gamesof syncing it with broadcast_asid_used. Why wouldn't broadcast_asid_usedsuffice?

Follow-Ups:
- Re: [PATCH 09/12] x86/mm: enable broadcast TLB invalidation for multi-threaded processes
  - From: Karim Manaouil

References:
- [PATCH v3 00/12] AMD broadcast TLB invalidation
  - From: Rik van Riel
- [PATCH 09/12] x86/mm: enable broadcast TLB invalidation for multi-threaded processes
  - From: Rik van Riel
- Re: [PATCH 09/12] x86/mm: enable broadcast TLB invalidation for multi-threaded processes
  - From: Nadav Amit
- Re: [PATCH 09/12] x86/mm: enable broadcast TLB invalidation for multi-threaded processes
  - From: Rik van Riel

Prev by Date: [syzbot] [mm?] WARNING in vma_merge_existing_range
Next by Date: Re: [PATCH 09/12] x86/mm: enable broadcast TLB invalidation for multi-threaded processes
Previous by thread: Re: [PATCH 09/12] x86/mm: enable broadcast TLB invalidation for multi-threaded processes
Next by thread: Re: [PATCH 09/12] x86/mm: enable broadcast TLB invalidation for multi-threaded processes
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]