On 17/12/24 9:48 am, Matthew Wilcox wrote:
On Mon, Dec 16, 2024 at 10:20:54PM +0530, Dev Jain wrote:
-static int hpage_collapse_scan_pmd(struct mm_struct *mm,
+static int hpage_collapse_scan_ptes(struct mm_struct *mm,
i don't think this is necessary at all. you're scanning a pmd.
you might not be scanning in order to collapse to a pmd, but pmd
is the level you're scanning at.
I did that if at all in the review process we note that we need to even drop
down the starting scan order, so that we do not skip smaller VMAs. I kinda
agree with you so till that time I have no problem reverting.