Re: [RFC PATCH 01/12] khugepaged: Rename hpage_collapse_scan_pmd() -> ptes()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dev Jain <dev.jain@xxxxxxx>
Subject: Re: [RFC PATCH 01/12] khugepaged: Rename hpage_collapse_scan_pmd() -> ptes()
From: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Date: Tue, 17 Dec 2024 04:18:46 +0000
Cc: akpm@xxxxxxxxxxxxxxxxxxxx, david@xxxxxxxxxx, kirill.shutemov@xxxxxxxxxxxxxxx, ryan.roberts@xxxxxxx, anshuman.khandual@xxxxxxx, catalin.marinas@xxxxxxx, cl@xxxxxxxxxx, vbabka@xxxxxxx, mhocko@xxxxxxxx, apopple@xxxxxxxxxx, dave.hansen@xxxxxxxxxxxxxxx, will@xxxxxxxxxx, baohua@xxxxxxxxxx, jack@xxxxxxx, srivatsa@xxxxxxxxxxxxx, haowenchao22@xxxxxxxxx, hughd@xxxxxxxxxx, aneesh.kumar@xxxxxxxxxx, yang@xxxxxxxxxxxxxxxxxxxxxx, peterx@xxxxxxxxxx, ioworker0@xxxxxxxxx, wangkefeng.wang@xxxxxxxxxx, ziy@xxxxxxxxxx, jglisse@xxxxxxxxxx, surenb@xxxxxxxxxx, vishal.moola@xxxxxxxxx, zokeefe@xxxxxxxxxx, zhengqi.arch@xxxxxxxxxxxxx, jhubbard@xxxxxxxxxx, 21cnbao@xxxxxxxxx, linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20241216165105.56185-2-dev.jain@arm.com>
References: <20241216165105.56185-1-dev.jain@arm.com> <20241216165105.56185-2-dev.jain@arm.com>

On Mon, Dec 16, 2024 at 10:20:54PM +0530, Dev Jain wrote:
> -static int hpage_collapse_scan_pmd(struct mm_struct *mm,
> +static int hpage_collapse_scan_ptes(struct mm_struct *mm,

i don't think this is necessary at all.  you're scanning a pmd.
you might not be scanning in order to collapse to a pmd, but pmd
is the level you're scanning at.

Follow-Ups:
- Re: [RFC PATCH 01/12] khugepaged: Rename hpage_collapse_scan_pmd() -> ptes()
  - From: Ryan Roberts
- Re: [RFC PATCH 01/12] khugepaged: Rename hpage_collapse_scan_pmd() -> ptes()
  - From: Dev Jain

References:
- [RFC PATCH 00/12] khugepaged: Asynchronous mTHP collapse
  - From: Dev Jain
- [RFC PATCH 01/12] khugepaged: Rename hpage_collapse_scan_pmd() -> ptes()
  - From: Dev Jain

Prev by Date: Re: [RFC PATCH 02/12] khugepaged: Generalize alloc_charge_folio()
Next by Date: Re: [RFC PATCH 03/12] khugepaged: Generalize hugepage_vma_revalidate()
Previous by thread: [RFC PATCH 01/12] khugepaged: Rename hpage_collapse_scan_pmd() -> ptes()
Next by thread: Re: [RFC PATCH 01/12] khugepaged: Rename hpage_collapse_scan_pmd() -> ptes()
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]