On 12/10/24 4:13 AM, Christoph Hellwig wrote: > On Tue, Dec 03, 2024 at 08:31:37AM -0700, Jens Axboe wrote: >> +static int filemap_create_folio(struct kiocb *iocb, >> + struct address_space *mapping, struct folio_batch *fbatch) > > We might as well drop passing the mapping and deriving it from the iocb > as well. > > Otherwise this looks fine to me. Sure, I can do that cleanup at the same time. -- Jens Axboe