Re: [PATCH 01/12] mm/filemap: change filemap_create_folio() to take a struct kiocb

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Jens Axboe <axboe@xxxxxxxxx>
Subject: Re: [PATCH 01/12] mm/filemap: change filemap_create_folio() to take a struct kiocb
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 10 Dec 2024 03:13:11 -0800
Cc: linux-mm@xxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, hannes@xxxxxxxxxxx, clm@xxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, willy@xxxxxxxxxxxxx, kirill@xxxxxxxxxxxxx, bfoster@xxxxxxxxxx
In-reply-to: <20241203153232.92224-3-axboe@kernel.dk>
References: <20241203153232.92224-2-axboe@kernel.dk> <20241203153232.92224-3-axboe@kernel.dk>

On Tue, Dec 03, 2024 at 08:31:37AM -0700, Jens Axboe wrote:
> +static int filemap_create_folio(struct kiocb *iocb,
> +		struct address_space *mapping, struct folio_batch *fbatch)

We might as well drop passing the mapping and deriving it from the iocb
as well.

Otherwise this looks fine to me.

Follow-Ups:
- Re: [PATCH 01/12] mm/filemap: change filemap_create_folio() to take a struct kiocb
  - From: Jens Axboe

References:
- [PATCHSET v6 0/12] Uncached buffered IO
  - From: Jens Axboe
- [PATCH 01/12] mm/filemap: change filemap_create_folio() to take a struct kiocb
  - From: Jens Axboe

Prev by Date: Re: [PATCHSET v6 0/12] Uncached buffered IO
Next by Date: Re: [PATCH 05/12] mm/filemap: use page_cache_sync_ra() to kick off read-ahead
Previous by thread: [PATCH 01/12] mm/filemap: change filemap_create_folio() to take a struct kiocb
Next by thread: Re: [PATCH 01/12] mm/filemap: change filemap_create_folio() to take a struct kiocb
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]

Powered by Linux