On Thu, Nov 07, 2024 at 03:43:00PM +0100, Sebastian Andrzej Siewior wrote:
> On 2024-11-07 06:08:35 [-0800], Paul E. McKenney wrote:
> …
> > This statement in scf_torture_cleanup() is supposed to wait for all
> > outstanding IPIs:
> >
> > smp_call_function(scf_cleanup_handler, NULL, 0);
>
> This should be
> smp_call_function(scf_cleanup_handler, NULL, 1);
>
> so it queues the function call and waits for its completion. Otherwise
> it is queued and might be invoked _later_.
>
> > And the scf_cleanup_handler() function is as follows:
> >
> > static void scf_cleanup_handler(void *unused)
> > {
> > }
> >
> > Does that work, or am I yet again being overly naive?
>
> See above. I can send a patch later on if you have no other complains ;)
You got me on that one! Thank you, and please do feel free to send
a patch.
Interestingly enough, this has never failed. Perhaps because the usual
scftorture run injects enough idle time that all the IPIs have time
to finish. ;-)
Thanx, Paul
