> On Tue, Aug 14, 2012 at 04:19:55PM +0200, Michal Nazarewicz wrote: >> Since CMA is the only user of MIGRATE_DISCARD it may be worth it to >> guard it inside an #ifdef, eg: Minchan Kim <minchan@xxxxxxxxxx> writes: > In summary, I want to open it for potential usecases in future if anyone > doesn't oppose strongly. Fair enough. >>> if (!trylock_page(page)) { >>> - if (!force || mode == MIGRATE_ASYNC) >>> + if (!force || mode & MIGRATE_ASYNC) > It's not wrong technically but for readability, NP. Yep, that was my point, thanks. :) -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +----<email/xmpp: mpn@xxxxxxxxxx>--------------ooO--(_)--Ooo--
Attachment:
pgpSvhhXyfaX8.pgp
Description: PGP signature