On 9/12/24 10:32, Christoph Hellwig wrote:
On Wed, Sep 11, 2024 at 05:34:42PM +0100, Pavel Begunkov wrote:
Add a second io_uring cmd for block layer implementing asynchronous
write zeroes. It reuses helpers we've added for async discards, and
inherits the code structure as well as all considerations in regards to
page cache races. It has to be supported by underlying hardware to be
used, otherwise the request will fail. A fallback version is implemented
separately in a later patch.
Except that as far as I can tell it doesn't implement a fallback, but
I could've worded it better, but it doesn't say anything about
implementing fallback for this opcode.
an entirely different command leading to applications breaking when
just using the command and the hardware doesn't support it.
Nacked-by: Christoph Hellwig <hch@xxxxxx>
to this incomplete API that will just create incompatbilities.
That's fine, I'd rather take your nack than humouring the idea
of having a worse api than it could be.
--
Pavel Begunkov
