On 9/12/24 10:25 AM, Pavel Begunkov wrote: >> an entirely different command leading to applications breaking when >> just using the command and the hardware doesn't support it. >> >> Nacked-by: Christoph Hellwig <hch@xxxxxx> >> >> to this incomplete API that will just create incompatbilities. > > That's fine, I'd rather take your nack than humouring the idea > of having a worse api than it could be. How about we just drop 6-8 for now, and just focus on getting the actual main discard operation in? That's (by far) the most important anyway, and we can always add the write-zeroes bit later. -- Jens Axboe