On 04.09.24 12:15, Alice Ryhl wrote: > On Tue, Sep 3, 2024 at 2:03 PM Danilo Krummrich <dakr@xxxxxxxxxx> wrote: >> >> On Sat, Aug 31, 2024 at 01:57:12PM +0100, Gary Guo wrote: >>> On Fri, 16 Aug 2024 02:11:08 +0200 >>> Danilo Krummrich <dakr@xxxxxxxxxx> wrote: >>> >>>> Add maintainers entry for the Rust `alloc` module. >>>> >>>> Currently, this includes the `Allocator` API itself, `Allocator` >>>> implementations, such as `Kmalloc` or `Vmalloc`, as well as the kernel's >>>> implementation of the primary memory allocation data structures, `Box` >>>> and `Vec`. >>>> >>>> Signed-off-by: Danilo Krummrich <dakr@xxxxxxxxxx> >>>> --- >>>> MAINTAINERS | 7 +++++++ >>>> 1 file changed, 7 insertions(+) >>>> >>>> diff --git a/MAINTAINERS b/MAINTAINERS >>>> index 42decde38320..560516b3aaf4 100644 >>>> --- a/MAINTAINERS >>>> +++ b/MAINTAINERS >>>> @@ -19925,6 +19925,13 @@ F: scripts/*rust* >>>> F: tools/testing/selftests/rust/ >>>> K: \b(?i:rust)\b >>>> >>>> +RUST [ALLOC] >>>> +M: Danilo Krummrich <dakr@xxxxxxxxxx> >>>> +L: rust-for-linux@xxxxxxxxxxxxxxx >>>> +S: Maintained >>>> +F: rust/kernel/alloc.rs >>>> +F: rust/kernel/alloc/ >>> >>> It feels like we should use `mod.rs`. >> >> The same would be true for: >> >> - rust/kernel/sync.rs >> - rust/kernel/net.rs >> - rust/kernel/init.rs >> - rust/kernel/fs.rs >> - ... >> >> Do you propose to change it for all of them? > > I do actually think `mod.rs` is superior in general, but it's probably > not worth changing it right now. I forgot the reason for not using it, does anyone remember? --- Cheers, Benno
