On (24/09/03 14:28), Andrew Morton wrote: > On Tue, 3 Sep 2024 13:55:28 -0400 Johannes Weiner <hannes@xxxxxxxxxxx> wrote: > > > On Tue, Sep 03, 2024 at 01:00:22PM +0900, Sergey Senozhatsky wrote: > > > zsmalloc is not exclusive to zswap. Commit aa3ba6d72ce0 > > > ("mm: Kconfig: fixup zsmalloc configuration") made CONFIG_ZSMALLOC > > > only visible when CONFIG_ZSWAP is selected, which makes it > > > impossible to menuconfig zsmalloc-specific features (stats, > > > chain-size, etc.) on systems that use ZRAM but don't have ZSWAP > > > enabled. > > > > > > Make zsmalloc depend on both ZRAM and ZSWAP. > > > > > > Fixes: Fixes: aa3ba6d72ce0 ("mm: Kconfig: fixup zsmalloc configuration") > > > > I can't find this commit upstream. > > > > It looks like this was actually broken by > > > > commit b3fbd58fcbb10725a1314688e03b1af6827c42f9 > > Author: Johannes Weiner <hannes@xxxxxxxxxxx> > > Date: Thu May 19 14:08:53 2022 -0700 > > > > mm: Kconfig: simplify zswap configuration > > > > instead? > > Agree, I edited that into the changelog. My bad, I didn't pay attention to what checkpatch suggested as an edit. Thanks for spotting this Johannes and thanks for fixing this up Andrew!