On Tue, Sep 03, 2024 at 01:00:22PM +0900, Sergey Senozhatsky wrote:
> zsmalloc is not exclusive to zswap. Commit aa3ba6d72ce0
> ("mm: Kconfig: fixup zsmalloc configuration") made CONFIG_ZSMALLOC
> only visible when CONFIG_ZSWAP is selected, which makes it
> impossible to menuconfig zsmalloc-specific features (stats,
> chain-size, etc.) on systems that use ZRAM but don't have ZSWAP
> enabled.
>
> Make zsmalloc depend on both ZRAM and ZSWAP.
>
> Fixes: Fixes: aa3ba6d72ce0 ("mm: Kconfig: fixup zsmalloc configuration")
I can't find this commit upstream.
It looks like this was actually broken by
commit b3fbd58fcbb10725a1314688e03b1af6827c42f9
Author: Johannes Weiner <hannes@xxxxxxxxxxx>
Date: Thu May 19 14:08:53 2022 -0700
mm: Kconfig: simplify zswap configuration
instead?
The patch itself looks good to me.
> Signed-off-by: Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx>
> ---
> mm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/Kconfig b/mm/Kconfig
> index b23913d4e47e..1aa282e35dc7 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -188,7 +188,7 @@ config Z3FOLD
>
> config ZSMALLOC
> tristate
> - prompt "N:1 compression allocator (zsmalloc)" if ZSWAP
> + prompt "N:1 compression allocator (zsmalloc)" if (ZSWAP || ZRAM)
> depends on MMU
> help
> zsmalloc is a slab-based memory allocator designed to store
> --
> 2.46.0.469.g59c65b2a67-goog
>
