On Mon, 2 Sep 2024 09:10:33 +0300 Gal Pressman wrote: > > You don't explain the 'why'. How is this an improvement? > > nack on this and 2 similar networking changes you sent > > Are you against the concept of string_choices in general, or this > specific change? Willem verbalized my opinion better than I can. If a (driver|subsystem) maintainer likes string_choices that's perfectly fine, but IMHO they are not worth converting to, and not something we should suggest during review.
