On Sat, 31 Aug 2024 17:58:38 +0800 Hongbo Li wrote: > Use str_disabled_enabled() helper instead of open > coding the same. > diff --git a/drivers/net/tun.c b/drivers/net/tun.c > index 6fe5e8f7017c..29647704bda8 100644 > --- a/drivers/net/tun.c > +++ b/drivers/net/tun.c > @@ -3178,7 +3178,7 @@ static long __tun_chr_ioctl(struct file *file, unsigned int cmd, > > /* [unimplemented] */ > netif_info(tun, drv, tun->dev, "ignored: set checksum %s\n", > - arg ? "disabled" : "enabled"); > + str_disabled_enabled(arg)); You don't explain the 'why'. How is this an improvement? nack on this and 2 similar networking changes you sent
