On Fri, Aug 10, 2012 at 9:21 PM, Hillf Danton <dhillf@xxxxxxxxx> wrote: > On Fri, Aug 10, 2012 at 9:16 PM, Michal Hocko <mhocko@xxxxxxx> wrote: >> Subject: [PATCH] hugetlb: do not use vma_hugecache_offset for >> vma_prio_tree_foreach >> >> 0c176d5 (mm: hugetlb: fix pgoff computation when unmapping page >> from vma) fixed pgoff calculation but it has replaced it by >> vma_hugecache_offset which is not approapriate for offsets used for >> vma_prio_tree_foreach because that one expects index in page units >> rather than in huge_page_shift. >> Using vma_hugecache_offset is not incorrect because the pgoff will fit >> into the same vmas but it is confusing. >> > > Well, how is the patch tested? You see, Michal, it is weekend and I have to be offline now. See you next week ;) Hillf -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>