On Fri, Aug 10, 2012 at 8:27 PM, Michal Hocko <mhocko@xxxxxxx> wrote: > > I guess you mean unmap_ref_private and that has been changed by you > (0c176d5 mm: hugetlb: fix pgoff computation when unmapping page from > vma)... I was wrong at that time when giving my Reviewed-by. The patch > didn't break anything because you still find all relevant vmas because > vma_hugecache_offset just provides a smaller index which is still within > boundaries. No, as shown by the log message of 0c176d52b, that fix was triggered by (vma->vm_pgoff >> PAGE_SHIFT), thus I dont see what you really want to revert. > I think that 0c176d52 should be reverted because we do not have to refer > to the head page in this case and as we can see it causes confusion. > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>