On Thu, Aug 08, 2024 at 12:53:55PM -0400, Liam R. Howlett wrote: >* Wei Yang <richard.weiyang@xxxxxxxxx> [240808 00:38]: >> If entry is a special case, we need to expand root to store it. This >> case is exactly the case of xa_is_internal(). >> >> Let's use xa_is_internal() for the check, which is friendly for >> audience. > >Nack > >This check is to see if it will be detected as an internal node - this >much is correct. > >But changing the check to use this function reads far worse than what >exists today. If you look at the code below, it seems to indicate that >the internal entry is being inserted into the tree - but it's not an >internal entry, it's an entry that would be detected as an internal >entry. >
