On Tue, 6 Aug 2024 at 11:16, Brian Mak <makb@xxxxxxxxxxx> wrote:
>
> @@ -1253,5 +1266,8 @@ static bool dump_vma_snapshot(struct coredump_params *cprm)
> cprm->vma_data_size += m->dump_size;
> }
>
> + sort(cprm->vma_meta, cprm->vma_count, sizeof(*cprm->vma_meta),
> + cmp_vma_size, NULL);
> +
> return true;
> }
Hmm. Realistically we only dump core in ELF, and the order of the
segments shouldn't matter.
But I wonder if we should do this in the ->core_dump() function
itself, in case it would have mattered for other dump formats?
IOW, instead of being at the bottom of dump_vma_snapshot(), maybe the
sorting should be at the top of elf_core_dump()?
And yes, in practice I doubt we'll ever have other dump formats, and
no, a.out isn't doing some miraculous comeback either.
But I bet you didn't test elf_fdpic_core_dump() even if I bet it (a)
works and (b) nobody cares.
So moving it to the ELF side might be conceptually the right thing to do?
(Or is there some reason it needs to be done at snapshot time that I
just didn't fully appreciate?)
Linus
