On 7/31/24 10:16 AM, Sergey Senozhatsky wrote: > On (24/07/30 19:45), Alex Shi wrote: >> On 7/30/24 5:37 PM, Sergey Senozhatsky wrote: >>> On (24/07/29 19:25), alexs@xxxxxxxxxx wrote: >>>> >>>> From: Alex Shi <alexs@xxxxxxxxxx> >>>> >>> >>> Usually some simple commit message is still expected. >> >> Uh, my fault. Just forgive this part, is the following log fine? >> >> After the page to zpdesc conversion, there still left few comments or >> function named with page not zpdesc, let's update the comments and >> rename function create_page_chain() as create_zpdesc_chain(). > > A bit of a different thing, still documentation related tho: do > we want to do something about comments that mention page_lock in > zsmalloc.c? Good question! There are some comments mentioned about the page_lock in the file, but missed in the header of file, so how about the following adding: diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 731055ccef23..eac110edbff0 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -25,6 +25,8 @@ * * Usage of struct zpdesc(page) flags: * PG_private: identifies the first component page + * PG_lock: lock all component pages for a zspage free, serialize with + * migration */ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt Thanks a lot!
