On 08/02/2012 06:03 PM, Eric W. Biederman wrote: > Sasha Levin <levinsasha928@xxxxxxxxx> writes: >> On 08/02/2012 12:32 PM, Josh Triplett wrote: >>> What about using a C99 flexible array member? Kernel style prohibits >>> variable-length arrays, but I don't think the same rationale applies to >>> flexible array members. >>> >>> struct hash_table { >>> size_t count; >>> struct hlist_head buckets[]; >>> }; >>> >>> #define DEFINE_HASH_TABLE(name, length) struct hash_table name = { .count = length, .buckets = { [0 ... (length - 1)] = HLIST_HEAD_INIT } } >> >> The limitation of this approach is that the struct hash_table variable >> must be 'static', which is a bit limiting - see for example the use of >> hashtable in 'struct user_namespace'. > > You mean the hash table that was made static in 3.5? > > You might want to try basing your patches on something a little more current. > > Eric > Heh, I've started working on it in April, and just returned to this. Didn't think about rebasing to something new. will fix - Thanks! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>