Re: Common [00/16] Sl[auo]b: Common code rework V8

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/02/2012 01:11 AM, Christoph Lameter wrote:
> 
> V7->V8:
> - Do not use kfree for kmem_cache in slub.
> - Add more patches up to a common
>   scheme for object alignment.

I will review the new patchset anyway. But I believe this is a bad move.
This code is subtle, and all previous pieces that got merged led to
bugs. Which is fine in principle, but indicates that we should move and
review with care. Adding more code to the pool defeats this. I'd say
let's merge what was already reviewed, and then take the next step.

That said, unless I am missing something, you seem to have added nothing
in the middle of the series, all new patches go in the end. Am I right?
In this case, we could merge patches 1-9 if Pekka is fine with them, and
then move on.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]