Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Barry Song <21cnbao@xxxxxxxxx>
Subject: Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
From: Michal Hocko <mhocko@xxxxxxxx>
Date: Fri, 19 Jul 2024 15:30:54 +0200
Cc: Vlastimil Babka <vbabka@xxxxxxx>, akpm@xxxxxxxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Barry Song <v-songbaohua@xxxxxxxx>, Uladzislau Rezki <urezki@xxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Lorenzo Stoakes <lstoakes@xxxxxxxxx>, Christoph Lameter <cl@xxxxxxxxx>, Pekka Enberg <penberg@xxxxxxxxxx>, David Rientjes <rientjes@xxxxxxxxxx>, Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>, Roman Gushchin <roman.gushchin@xxxxxxxxx>, Hyeonggon Yoo <42.hyeyoo@xxxxxxxxx>
In-reply-to: <CAGsJ_4yx=ug8hD7ZhF4y7UzYX-yUn9s_6h6utV+cr4FNkeVkow@mail.gmail.com>
References: <ZpoYyp8aHWGyCK-8@tiehlicka> <CAGsJ_4xpLf6qfvfNmowT01xF8ETBPM46-A=3umHEUXpk=fQ04A@mail.gmail.com> <ZpodRShdeVsFu_mH@tiehlicka> <b5b4001f-cfe3-48f7-8ce6-9be45432214b@suse.cz> <Zpoy3a2okecXv069@tiehlicka> <031ff35b-65f0-4ead-a08f-21711bad5e29@suse.cz> <ZppFadCp8iYHsSwJ@tiehlicka> <4a1bd482-bfff-4843-a60f-004b3a8a99e4@suse.cz> <ZppNVKK5rcs8WCJD@tiehlicka> <CAGsJ_4yx=ug8hD7ZhF4y7UzYX-yUn9s_6h6utV+cr4FNkeVkow@mail.gmail.com>

On Fri 19-07-24 21:02:10, Barry Song wrote:
> what about an earlier WARN_ON, for example, even before we begin to
> try the allocation?

Page allocator is a hot path and adding checks for something that
shouldn't really even exist is not a great addition there IMHO.

-- 
Michal Hocko
SUSE Labs

Follow-Ups:
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Barry Song

References:
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Michal Hocko
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Barry Song
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Michal Hocko
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Vlastimil Babka
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Michal Hocko
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Vlastimil Babka
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Michal Hocko
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Vlastimil Babka
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Michal Hocko
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Barry Song

Prev by Date: Re: [PATCH 2/2] mm: remove foll_flags in __get_user_pages
Next by Date: Re: [PATCH 00/17] mm: introduce numa_memblks
Previous by thread: Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
Next by thread: Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]