Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Vlastimil Babka <vbabka@xxxxxxx>
Subject: Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
From: Michal Hocko <mhocko@xxxxxxxx>
Date: Fri, 19 Jul 2024 11:33:17 +0200
Cc: Barry Song <21cnbao@xxxxxxxxx>, akpm@xxxxxxxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Barry Song <v-songbaohua@xxxxxxxx>, Uladzislau Rezki <urezki@xxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Lorenzo Stoakes <lstoakes@xxxxxxxxx>, Christoph Lameter <cl@xxxxxxxxx>, Pekka Enberg <penberg@xxxxxxxxxx>, David Rientjes <rientjes@xxxxxxxxxx>, Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>, Roman Gushchin <roman.gushchin@xxxxxxxxx>, Hyeonggon Yoo <42.hyeyoo@xxxxxxxxx>
In-reply-to: <b5b4001f-cfe3-48f7-8ce6-9be45432214b@suse.cz>
References: <ZpjTMc3wLuzFX6OD@tiehlicka> <CAGsJ_4wRa6YWY=7dMhv2BAX5Mdh0b9uy3=S9W6nd_-1yANb8Zg@mail.gmail.com> <ZpjXacbUGxTs9cR0@tiehlicka> <CAGsJ_4wNre89_pQWvU0jj6reLaETYOTUVu3DYwPo8Up1DM1-8A@mail.gmail.com> <ZpoPafjDrA4T_o0y@tiehlicka> <CAGsJ_4wbvNxDOYx0RNQd0vaH5KScPdJFvdi9SWkXVRF_41cVXA@mail.gmail.com> <ZpoYyp8aHWGyCK-8@tiehlicka> <CAGsJ_4xpLf6qfvfNmowT01xF8ETBPM46-A=3umHEUXpk=fQ04A@mail.gmail.com> <ZpodRShdeVsFu_mH@tiehlicka> <b5b4001f-cfe3-48f7-8ce6-9be45432214b@suse.cz>

On Fri 19-07-24 10:50:07, Vlastimil Babka wrote:
[...]
> That wouldn't mean the busy loop is a correct and supported practice. It
> would just mean it's the least bad of the bad options we have to deal with
> an allocation that's wrong but we didn't catch soon enough in the development.

So you want to make those potential BUG_ONs hard/soft lockups (not sure
all arches have a reliable detection) instead?

-- 
Michal Hocko
SUSE Labs

Follow-Ups:
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Vlastimil Babka

References:
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Michal Hocko
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Barry Song
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Michal Hocko
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Barry Song
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Michal Hocko
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Barry Song
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Michal Hocko
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Barry Song
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Michal Hocko
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Vlastimil Babka

Prev by Date: Re: [PATCH] mm: huge_memory: use !CONFIG_64BIT to relax huge page alignment on 32 bit machines
Next by Date: Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
Previous by thread: Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
Next by thread: Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]