Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Michal Hocko <mhocko@xxxxxxxx>
Subject: Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 19 Jul 2024 00:37:40 -0700
Cc: Barry Song <21cnbao@xxxxxxxxx>, akpm@xxxxxxxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Barry Song <v-songbaohua@xxxxxxxx>, Uladzislau Rezki <urezki@xxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Lorenzo Stoakes <lstoakes@xxxxxxxxx>, Christoph Lameter <cl@xxxxxxxxx>, Pekka Enberg <penberg@xxxxxxxxxx>, David Rientjes <rientjes@xxxxxxxxxx>, Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>, Roman Gushchin <roman.gushchin@xxxxxxxxx>, Hyeonggon Yoo <42.hyeyoo@xxxxxxxxx>
In-reply-to: <ZpoPafjDrA4T_o0y@tiehlicka>
References: <CAGsJ_4x0Bak+H0zJNH4FKLqd-Dmm4HhT5S4CzsoUaNiDKHNTtA@mail.gmail.com> <ZpjD7PKBOOzZU0sp@tiehlicka> <CAGsJ_4w0dJyJhYLe4T908=fGUC54yHcNaCA22QBN8OSkpxTrqg@mail.gmail.com> <ZpjJpvu5xWlDx4gD@tiehlicka> <CAGsJ_4wzpSLbteULhnTrQa_p5ETjiCTRHfF9Ph34=WZiub3irA@mail.gmail.com> <ZpjTMc3wLuzFX6OD@tiehlicka> <CAGsJ_4wRa6YWY=7dMhv2BAX5Mdh0b9uy3=S9W6nd_-1yANb8Zg@mail.gmail.com> <ZpjXacbUGxTs9cR0@tiehlicka> <CAGsJ_4wNre89_pQWvU0jj6reLaETYOTUVu3DYwPo8Up1DM1-8A@mail.gmail.com> <ZpoPafjDrA4T_o0y@tiehlicka>

On Fri, Jul 19, 2024 at 09:02:01AM +0200, Michal Hocko wrote:
> > Additionally, at least drivers/vdpa/vdpa_user/iova_domain.c is
> > incorrect with GFP_ATOMIC
> > | __GFP_NOFAIL.
> 
> This is broken! Please bring this up with the maintainer of the code.

No the only issue in this vdpa mess :(

But I wonder if we should have a macro/BUILD_BUG_ON magic to catch
totally obvious bugs like this.

Follow-Ups:
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Barry Song

References:
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Barry Song
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Michal Hocko
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Barry Song
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Michal Hocko
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Barry Song
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Michal Hocko
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Barry Song
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Michal Hocko
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Barry Song
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Michal Hocko

Prev by Date: Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
Next by Date: Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
Previous by thread: Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
Next by thread: Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]