Re: [PATCH v3 1/3] mm/memory-failure: userspace controls soft-offlining pages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Jiaqi Yan <jiaqiyan@xxxxxxxxxx>
Subject: Re: [PATCH v3 1/3] mm/memory-failure: userspace controls soft-offlining pages
From: Oscar Salvador <osalvador@xxxxxxx>
Date: Wed, 19 Jun 2024 07:23:46 +0200
Cc: nao.horiguchi@xxxxxxxxx, linmiaohe@xxxxxxxxxx, jane.chu@xxxxxxxxxx, ioworker0@xxxxxxxxx, muchun.song@xxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, shuah@xxxxxxxxxx, corbet@xxxxxxx, rientjes@xxxxxxxxxx, duenwen@xxxxxxxxxx, fvdl@xxxxxxxxxx, linux-mm@xxxxxxxxx, linux-kselftest@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx
In-reply-to: <ZnJmsqvJz63imq3O@localhost.localdomain>
References: <20240617170545.3820912-1-jiaqiyan@google.com> <20240617170545.3820912-2-jiaqiyan@google.com> <ZnJmsqvJz63imq3O@localhost.localdomain>

On Wed, Jun 19, 2024 at 07:03:46AM +0200, Oscar Salvador wrote:
> We should not be doing anything if soft_offline is disabled, so this check should
> be placed upfront, at the very beginning of the function.
> Then you can remove the 'put_ref_page' call.

Sorry, I managed to confuse myself, this has to stay as is.

-- 
Oscar Salvador
SUSE Labs

References:
- [PATCH v3 0/3] Userspace controls soft-offline pages
  - From: Jiaqi Yan
- [PATCH v3 1/3] mm/memory-failure: userspace controls soft-offlining pages
  - From: Jiaqi Yan
- Re: [PATCH v3 1/3] mm/memory-failure: userspace controls soft-offlining pages
  - From: Oscar Salvador

Prev by Date: Re: [PATCH] mm/page_alloc: skip THP-sized PCP list when allocating non-CMA THP-sized page
Next by Date: [PATCH v1] mm/memory-failure: refactor log format in unpoison_memory
Previous by thread: Re: [PATCH v3 1/3] mm/memory-failure: userspace controls soft-offlining pages
Next by thread: [PATCH] kunit/usercopy: Disable testing on !CONFIG_MMU
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]