Re: + memory-hotplug-fix-kswapd-looping-forever-problem-fix-fix.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello, Andrew.

On Fri, Jul 20, 2012 at 02:22:13PM -0700, Andrew Morton wrote:
> My point is that having to ensure that each arch zeroes out this
> structure is difficult/costly/unreliable/fragile.  It would be better
> if we can reliably clear it at some well-known place in core MM.
> 
> That might mean that the memory gets cleared twice on some
> architectures, but I doubt if that matters - it's a once-off thing.

Clearing twice isn't the problem here.  The problem is the risk of
zapping fields which are already in use.  That would be way more
unexpected and difficult to track down than garbage value in whatever
field.

It might not be ideal but I think nudging all archs to clear all
static global structures they allocate is the better way here.  It's
at least better than having to worry about this type of partial
re-initialization.

Thanks.

-- 
tejun

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]