On Tue, 17 Jul 2012, JoonSoo Kim wrote: > > Actually, it makes me wonder if there is any code that uses this > > information. If not, it would be best in my opinion to make it return > > zero or negative error code, but that would have to be checked. > > I think that, too. > I looked at every callsites for migrate_pages() and there is no place > which really need fail count. > This function sometimes makes caller error-prone, > so I think changing return value is preferable. > > How do you think, Christoph? We could do that. I am not aware of anything using that information either. However, the condition in which some pages where migrated and others are not is not like a classic error. In many situations the moving of the pages is done for performance reasons. This just means that the best performant memory locations could not be used for some pages. A situation like that may be ok for an application. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>