2012/7/17 Michal Nazarewicz <mina86@xxxxxxx>: > Acked-by: Michal Nazarewicz <mina86@xxxxxxxxxx> Thanks. > Actually, it makes me wonder if there is any code that uses this > information. If not, it would be best in my opinion to make it return > zero or negative error code, but that would have to be checked. I think that, too. I looked at every callsites for migrate_pages() and there is no place which really need fail count. This function sometimes makes caller error-prone, so I think changing return value is preferable. How do you think, Christoph? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>