On Tue, Apr 30, 2024 at 10:41:01AM -0700, Yosry Ahmed wrote: > On Tue, Apr 30, 2024 at 10:38 AM Shakeel Butt <shakeel.butt@xxxxxxxxx> wrote: > > > > On Tue, Apr 30, 2024 at 01:41:38AM -0700, Yosry Ahmed wrote: > > > On Mon, Apr 29, 2024 at 11:06 PM Shakeel Butt <shakeel.butt@xxxxxxxxx> wrote: [...] > > > > > > nit: we could return here if (i < 0) like you did in > > > memcg_page_state() and others below, less indentation. Same for > > > lruvec_page_state_local(). > > > > > > > I have fixed this in the following patch which adds warnings. > > Yeah I saw that after reviewing this one. > > FWIW, *if* you respin this, fixing this here would reduce the diff > noise in the patch that adds the warnings. Yeah, if I need to respin, I will change this.
