On Tue, Apr 23, 2024 at 04:30:20PM -0400, Johannes Weiner wrote: > On Tue, Apr 23, 2024 at 09:27:07PM +0300, Andy Shevchenko wrote: > > On Tue, Apr 23, 2024 at 11:10:00AM -0700, Andrew Morton wrote: > > > On Tue, 23 Apr 2024 19:14:43 +0300 Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > > > In some configurations I got > > > > mm/page_alloc.c:656:20: warning: unused function 'add_to_free_list' [-Wunused-function] > > > > Becuase the only user is guarged with a certain ifdeffery, > > > > do the same for add_to_free_list(). > > > > ... > > > > > Thanks, I'll queue this as a fix against "mm: page_alloc: consolidate > > > free page accounting". > > > > Thank you! > > Thanks for the fix. We switched most callsites to __add_to_free_list() > now, I didn't realize the memory failure code was the only one left. You're welcome! Hint to the future `make W=1` should be a must during development. > Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx> -- With Best Regards, Andy Shevchenko
