In some configurations I got mm/page_alloc.c:656:20: warning: unused function 'add_to_free_list' [-Wunused-function] Becuase the only user is guarged with a certain ifdeffery, do the same for add_to_free_list(). Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> --- v2: moved the function down to the respective ifdeffery block (Liam) mm/page_alloc.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 33d4a1be927b..cd584aace6bf 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -653,14 +653,6 @@ static inline void __add_to_free_list(struct page *page, struct zone *zone, area->nr_free++; } -static inline void add_to_free_list(struct page *page, struct zone *zone, - unsigned int order, int migratetype, - bool tail) -{ - __add_to_free_list(page, zone, order, migratetype, tail); - account_freepages(zone, 1 << order, migratetype); -} - /* * Used for pages which are on another list. Move the pages to the tail * of the list - so the moved pages won't immediately be considered for @@ -6776,6 +6768,14 @@ bool is_free_buddy_page(const struct page *page) EXPORT_SYMBOL(is_free_buddy_page); #ifdef CONFIG_MEMORY_FAILURE +static inline void add_to_free_list(struct page *page, struct zone *zone, + unsigned int order, int migratetype, + bool tail) +{ + __add_to_free_list(page, zone, order, migratetype, tail); + account_freepages(zone, 1 << order, migratetype); +} + /* * Break down a higher-order page in sub-pages, and keep our target out of * buddy allocator. -- 2.43.0.rc1.1336.g36b5255a03ac