On Thu, Mar 21, 2024 at 11:50 AM Yosry Ahmed <yosryahmed@xxxxxxxxxx> wrote: > > On Wed, Mar 20, 2024 at 09:26:43PM -0700, Chris Li wrote: > > > > > Another idea is we can make the zero fill zswap entry immutable and > > share by different pages. That way it does not depend on the xarray > > pointer tagging. It can share the same code path with existing zero > > fill page handling. Just don't free the zero fill entry. > > The only relevant item in zswap_entry for same-filled pages is objcg. > That cannot be shared by different pages anyway. So basically the Ah, good points about the objcg can't be shared. Chris