On Fri, Jun 29, 2012 at 01:15:43PM +0000, Cong Wang wrote:
>
> On Fri, 29 Jun 2012 at 04:51 GMT, Minchan Kim <minchan@xxxxxxxxxx> wrote:
> > 09f363c7 fixed shrinker callback returns -1 when nr_to_scan is zero
> > for preventing excessive the slab scanning. But 635697c6 fixed the
> > problem, again so we can freely return -1 although nr_to_scan is zero.
> > So let's revert 09f363c7 because the comment added in 09f363c7 made a
> > unnecessary rule shrinker user should be aware of.
> >
>
> Please also include the subject of the commit, not just raw hash number. ;)
>
> For example,
>
> 09f363c7("vmscan: fix shrinker callback bug in fs/super.c")
> 635697c6("vmscan: fix initial shrinker size handling")
Yeb. It seems akpm handled it by himself.
But I will keep in mind.
Thanks, Cong!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>