On Tue, Feb 13, 2024 at 10:54:07PM +0100, Pankaj Raghav (Samsung) wrote: > On Wed, Feb 14, 2024 at 08:19:23AM +1100, Dave Chinner wrote: > > On Tue, Feb 13, 2024 at 10:37:12AM +0100, Pankaj Raghav (Samsung) wrote: > > > From: Pankaj Raghav <p.raghav@xxxxxxxxxxx> > > > > > > Add an experimental CONFIG_XFS_LBS option to enable LBS support in XFS. > > > Retain the ASSERT for PAGE_SHIFT if CONFIG_XFS_LBS is not enabled. > > > > > > Signed-off-by: Pankaj Raghav <p.raghav@xxxxxxxxxxx> > > > > NAK. > > > > There it no reason for this existing - the same code is run > > regardless of the state of this config variable just with a > > difference in min folio order. All it does is increase the test > > matrix arbitrarily - now we have two kernel configs we have to test > > and there's no good reason for doing that. > > I did not have this CONFIG in the first round but I thought it might > help retain the existing behaviour until we deem the feature stable. > > But I get your point. So we remove this CONFIG and just have an > experimental warning during mount when people are using the LBS support? Yes. -Dave. -- Dave Chinner david@xxxxxxxxxxxxx
