On Tue, Feb 13, 2024 at 10:37:12AM +0100, Pankaj Raghav (Samsung) wrote: > From: Pankaj Raghav <p.raghav@xxxxxxxxxxx> > > Add an experimental CONFIG_XFS_LBS option to enable LBS support in XFS. > Retain the ASSERT for PAGE_SHIFT if CONFIG_XFS_LBS is not enabled. > > Signed-off-by: Pankaj Raghav <p.raghav@xxxxxxxxxxx> NAK. There it no reason for this existing - the same code is run regardless of the state of this config variable just with a difference in min folio order. All it does is increase the test matrix arbitrarily - now we have two kernel configs we have to test and there's no good reason for doing that. -Dave. -- Dave Chinner david@xxxxxxxxxxxxx