tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 2863b714f3ad0a9686f2de1b779228ad8c7a8052 commit: e3fe8d28c67bf6c291e920c6d04fa22afa14e6e4 [13015/13783] virtio_net: Fix "‘%d’ directive writing between 1 and 11 bytes into a region of size 10" warnings config: x86_64-sof-customedconfig-avs-defconfig (https://download.01.org/0day-ci/archive/20240119/202401190425.IGYMqCJW-lkp@xxxxxxxxx/config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240119/202401190425.IGYMqCJW-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202401190425.IGYMqCJW-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): drivers/net/virtio_net.c: In function 'init_vqs': drivers/net/virtio_net.c:4339:36: error: 'sprintf' may write a terminating nul past the end of the destination [-Werror=format-overflow=] sprintf(vi->rq[i].name, "input.%u", i); ^ drivers/net/virtio_net.c:4339:3: note: 'sprintf' output between 8 and 17 bytes into a destination of size 16 sprintf(vi->rq[i].name, "input.%u", i); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/net/virtio_net.c:4340:35: error: '%u' directive writing between 1 and 10 bytes into a region of size 9 [-Werror=format-overflow=] sprintf(vi->sq[i].name, "output.%u", i); ^~ drivers/net/virtio_net.c:4340:27: note: directive argument in the range [0, 2147483647] sprintf(vi->sq[i].name, "output.%u", i); ^~~~~~~~~~~ drivers/net/virtio_net.c:4340:3: note: 'sprintf' output between 9 and 18 bytes into a destination of size 16 sprintf(vi->sq[i].name, "output.%u", i); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors vim +4340 drivers/net/virtio_net.c 4293 4294 static int virtnet_find_vqs(struct virtnet_info *vi) 4295 { 4296 vq_callback_t **callbacks; 4297 struct virtqueue **vqs; 4298 const char **names; 4299 int ret = -ENOMEM; 4300 int total_vqs; 4301 bool *ctx; 4302 u16 i; 4303 4304 /* We expect 1 RX virtqueue followed by 1 TX virtqueue, followed by 4305 * possible N-1 RX/TX queue pairs used in multiqueue mode, followed by 4306 * possible control vq. 4307 */ 4308 total_vqs = vi->max_queue_pairs * 2 + 4309 virtio_has_feature(vi->vdev, VIRTIO_NET_F_CTRL_VQ); 4310 4311 /* Allocate space for find_vqs parameters */ 4312 vqs = kcalloc(total_vqs, sizeof(*vqs), GFP_KERNEL); 4313 if (!vqs) 4314 goto err_vq; 4315 callbacks = kmalloc_array(total_vqs, sizeof(*callbacks), GFP_KERNEL); 4316 if (!callbacks) 4317 goto err_callback; 4318 names = kmalloc_array(total_vqs, sizeof(*names), GFP_KERNEL); 4319 if (!names) 4320 goto err_names; 4321 if (!vi->big_packets || vi->mergeable_rx_bufs) { 4322 ctx = kcalloc(total_vqs, sizeof(*ctx), GFP_KERNEL); 4323 if (!ctx) 4324 goto err_ctx; 4325 } else { 4326 ctx = NULL; 4327 } 4328 4329 /* Parameters for control virtqueue, if any */ 4330 if (vi->has_cvq) { 4331 callbacks[total_vqs - 1] = NULL; 4332 names[total_vqs - 1] = "control"; 4333 } 4334 4335 /* Allocate/initialize parameters for send/receive virtqueues */ 4336 for (i = 0; i < vi->max_queue_pairs; i++) { 4337 callbacks[rxq2vq(i)] = skb_recv_done; 4338 callbacks[txq2vq(i)] = skb_xmit_done; 4339 sprintf(vi->rq[i].name, "input.%u", i); > 4340 sprintf(vi->sq[i].name, "output.%u", i); 4341 names[rxq2vq(i)] = vi->rq[i].name; 4342 names[txq2vq(i)] = vi->sq[i].name; 4343 if (ctx) 4344 ctx[rxq2vq(i)] = true; 4345 } 4346 4347 ret = virtio_find_vqs_ctx(vi->vdev, total_vqs, vqs, callbacks, 4348 names, ctx, NULL); 4349 if (ret) 4350 goto err_find; 4351 4352 if (vi->has_cvq) { 4353 vi->cvq = vqs[total_vqs - 1]; 4354 if (virtio_has_feature(vi->vdev, VIRTIO_NET_F_CTRL_VLAN)) 4355 vi->dev->features |= NETIF_F_HW_VLAN_CTAG_FILTER; 4356 } 4357 4358 for (i = 0; i < vi->max_queue_pairs; i++) { 4359 vi->rq[i].vq = vqs[rxq2vq(i)]; 4360 vi->rq[i].min_buf_len = mergeable_min_buf_len(vi, vi->rq[i].vq); 4361 vi->sq[i].vq = vqs[txq2vq(i)]; 4362 } 4363 4364 /* run here: ret == 0. */ 4365 4366 4367 err_find: 4368 kfree(ctx); 4369 err_ctx: 4370 kfree(names); 4371 err_names: 4372 kfree(callbacks); 4373 err_callback: 4374 kfree(vqs); 4375 err_vq: 4376 return ret; 4377 } 4378 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
