On Fri, 22 Jun 2012 17:10:59 -0400 KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxx> wrote: > On Fri, Jun 22, 2012 at 4:19 PM, Andrew Morton > <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > > On Thu, 14 Jun 2012 12:16:10 -0400 > > kosaki.motohiro@xxxxxxxxx wrote: > > > >> commit 2ff754fa8f (mm: clear pages_scanned only if draining a pcp adds pages > >> to the buddy allocator again) fixed one free_pcppages_bulk() misuse. But two > >> another miuse still exist. > > > > This changelog is irritating. __One can understand it a bit if one > > happens to have a git repo handy (and why do this to the reader?), but > > the changelog for 2ff754fa8f indicates that the patch might fix a > > livelock. __Is that true of this patch? __Who knows... > > The code in this simple patch speak the right usage, isn't it? It depends who is listening. Please, put yourself in the position of poor-scmuck@xxxxxxxxxxxxxxxx who is reading your patch and wondering whether it will fix some customer bug report he is working on. Or wondering whether he should backport it into his company's next kernel release. He simply won't be able to do this with the information which was provided here. And if we don't tell him, who will? > And yes, > this patch also fixes a possibility of live lock. (but i haven't seen actual > live lock cause from this mistake) hrm, I guess I'll put it in the 3.6 pile. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>