On Fri, Jun 22, 2012 at 4:19 PM, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > On Thu, 14 Jun 2012 12:16:10 -0400 > kosaki.motohiro@xxxxxxxxx wrote: > >> commit 2ff754fa8f (mm: clear pages_scanned only if draining a pcp adds pages >> to the buddy allocator again) fixed one free_pcppages_bulk() misuse. But two >> another miuse still exist. > > This changelog is irritating. One can understand it a bit if one > happens to have a git repo handy (and why do this to the reader?), but > the changelog for 2ff754fa8f indicates that the patch might fix a > livelock. Is that true of this patch? Who knows... The code in this simple patch speak the right usage, isn't it? And yes, this patch also fixes a possibility of live lock. (but i haven't seen actual live lock cause from this mistake) When anyone find a function misuse and fixes it, He/She should confirm other callsite and should all of mistake too. Otherwise we observe the same issue sooner of later. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href