On Sat, Jan 13, 2024 at 10:12:21AM +0100, Marco Elver wrote: > On Sat, 13 Jan 2024 at 02:24, Andi Kleen <ak@xxxxxxxxxxxxxxx> wrote: > > > > On Fri, Jan 12, 2024 at 11:15:05PM +0100, Marco Elver wrote: > > > + /* > > > + * Stack traces of size 0 are never saved, and we can simply use > > > + * the size field as an indicator if this is a new unused stack > > > + * record in the freelist. > > > + */ > > > + stack->size = 0; > > > > I would use WRITE_ONCE here too, at least for TSan. > > This is written with the pool_lock held. ...which doesn't help because the readers don't take it? -Andi