On Wed, Jan 03, 2024 at 03:55:38PM -0800, Darrick J. Wong wrote: > On Wed, Jan 03, 2024 at 08:41:17AM +0000, Christoph Hellwig wrote: > > shmem_read_mapping_page_gfp always returns an uptodate page or an > > ERR_PTR. Remove the code that tries to handle a non-uptodate page. > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > Hmm. xfile_pread calls shmem_read_mapping_page_gfp -> > shmem_read_folio_gfp -> shmem_get_folio_gfp(..., SGP_CACHE), right? > > Therefore, if the page is !uptodate then the "clear:" code will mark it > uptodate, right? And that's why xfile.c doesn't need to check uptodate? Yes.
