On Wed, Jan 03, 2024 at 03:48:49PM -0800, Darrick J. Wong wrote: > "To support these cases, a pair of ``xfile_obj_load`` and ``xfile_obj_store`` > functions are provided to read and persist objects into an xfile. An errors > encountered here are treated as an out of memory error." Ok. > > -DEFINE_XFILE_EVENT(xfile_pwrite); > > +DEFINE_XFILE_EVENT(xfile_obj_load); > > +DEFINE_XFILE_EVENT(xfile_obj_store); > > Want to shorten the names to xfile_load and xfile_store? That's really > what they're doing anyway. Fine with me. Just for the trace points or also for the functions? Also - returning ENOMEM for the API misuse cases (too large object, too large total size) always seemed weird to me. Is there a really strong case for it or should we go for actually useful errors for those?
