On Fri, Dec 1, 2023 at 6:10 PM Ilias Apalodimas <ilias.apalodimas@xxxxxxxxxx> wrote: > > re-sending as plain-text, apologize for the noise... > > On Fri, 1 Dec 2023 at 11:59, Ilias Apalodimas > <ilias.apalodimas@xxxxxxxxxx> wrote: > > > > Hi Liang, > > > > On Thu, 30 Nov 2023 at 13:59, Liang Chen <liangchen.linux@xxxxxxxxx> wrote: > >> > >> To support multiple users referencing the same fragment, pp_frag_count is > >> renamed to pp_ref_count to better reflect its actual meaning based on the > >> suggestion from [1]. > > The patch does more than what the description says and those should be > in 2 different patches. > I am ok with pp_frag_count -> pp_ref_count, for the functions I am not > sure the rename makes anything better. Yeah, the description doesn't adequately convey what the patch does. Before proceeding with splitting the patch, how about changing the description to the following? page_pool: transition to reference count management after page draining To support multiple users referencing the same fragment, 'pp_frag_count' is renamed to 'pp_ref_count', transitioning pp pages from fragment management to reference count management after draining based on the suggestion from [1]. The idea is that the concept of fragmenting exists before the page is drained, and all related functions retain their current names. However, once the page is drained, its management shifts to being governed by 'pp_ref_count'. Therefore, all functions associated with that lifecycle stage of a pp page are renamed. > > Jakub, are you ok with the name changes or is it going to make bisecting a pain? > > Thanks > /Ilias
