On Wed, Sep 13, 2023 at 7:15 PM <andrey.konovalov@xxxxxxxxx> wrote: > > From: Andrey Konovalov <andreyknvl@xxxxxxxxxx> > > Simplify comments accompanying the use of atomic accesses in the > stack depot code. > > Also drop smp_load_acquire from next_pool_required in depot_init_pool, > as both depot_init_pool and the all smp_store_release's to this variable > are executed under the stack depot lock. > > Signed-off-by: Andrey Konovalov <andreyknvl@xxxxxxxxxx> Reviewed-by: Alexander Potapenko <glider@xxxxxxxxxx> (but see below) > * Move on to the next pool. > * WRITE_ONCE pairs with potential concurrent read in > - * stack_depot_fetch(). > + * stack_depot_fetch. Why are you removing the parentheses here? kernel-doc uses them to tell functions from non-functions, and having them in non-doc comments sounds consistent.
