Re: [PATCH 03/12] filemap: update ki_pos in generic_perform_write

To: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 03/12] filemap: update ki_pos in generic_perform_write
From: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 13 Sep 2023 13:00:10 +0200
Cc: Christoph Hellwig <hch@xxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Xiubo Li <xiubli@xxxxxxxxxx>, Ilya Dryomov <idryomov@xxxxxxxxx>, Christian Brauner <brauner@xxxxxxxxxx>, "Theodore Ts'o" <tytso@xxxxxxx>, Jaegeuk Kim <jaegeuk@xxxxxxxxxx>, Chao Yu <chao@xxxxxxxxxx>, Miklos Szeredi <miklos@xxxxxxxxxx>, Andreas Gruenbacher <agruenba@xxxxxxxxxx>, "Darrick J. Wong" <djwong@xxxxxxxxxx>, Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx>, Anna Schumaker <anna@xxxxxxxxxx>, Damien Le Moal <dlemoal@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx, cluster-devel@xxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Hannes Reinecke <hare@xxxxxxx>
In-reply-to: <20230827214518.GU3390869@ZenIV>
References: <20230601145904.1385409-1-hch@lst.de> <20230601145904.1385409-4-hch@lst.de> <20230827194122.GA325446@ZenIV> <20230827214518.GU3390869@ZenIV>
User-agent: Mutt/1.5.17 (2007-11-01)

> direct_write_fallback(): on error revert the ->ki_pos update from buffered write

Al, Christian: can you send this fix on top Linus?

Follow-Ups:
- Re: [PATCH 03/12] filemap: update ki_pos in generic_perform_write
  - From: Christian Brauner

References:
- cleanup the filemap / direct I/O interaction v4
  - From: Christoph Hellwig
- [PATCH 03/12] filemap: update ki_pos in generic_perform_write
  - From: Christoph Hellwig
- Re: [PATCH 03/12] filemap: update ki_pos in generic_perform_write
  - From: Al Viro
- Re: [PATCH 03/12] filemap: update ki_pos in generic_perform_write
  - From: Al Viro